Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1908

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,40 @@
def format_linter_error(error: dict) -> dict:
# write your code here
pass
return {
"line": error["line_number"], "column": error["column_number"],
"message": error["text"], "name": error["code"], "source": "flake8"
}
Comment on lines +2 to +5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format_linter_error function is correctly implemented, but its logic is duplicated in the format_single_linter_file and format_linter_report functions. Consider creating a helper function to avoid repetition.



def format_single_linter_file(file_path: str, errors: list) -> dict:
# write your code here
pass
return {
"errors": [
{
"line": error["line_number"],
"column": error["column_number"],
"message": error["text"],
"name": error["code"], "source": "flake8"
}
Comment on lines +11 to +16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here duplicates the format_linter_error function. Consider using the format_linter_error function to format each error, which would make the code more maintainable and reduce duplication.

for error in errors
],
"path": file_path, "status": ("passed" if errors == [] else "failed")
}


def format_linter_report(linter_report: dict) -> list:
# write your code here
pass
return [
{
"errors": [
{
"line": error["line_number"],
"column": error["column_number"],
"message": error["text"],
"name": error["code"],
"source": "flake8"
}
Comment on lines +27 to +33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous comment, this logic duplicates the format_linter_error function. Refactoring to use format_linter_error would improve code maintainability.

for error in errors
],
"path": file,
"status": ("passed" if errors == [] else "failed")
}
for file, errors in linter_report.items()
]
Loading