-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1914
base: master
Are you sure you want to change the base?
Solution #1914
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,31 @@ | ||
def format_linter_error(error: dict) -> dict: | ||
# write your code here | ||
pass | ||
def format_linter_error(error): | ||
return { | ||
"line": error["line_number"], | ||
"column": error["column_number"], | ||
"message": error["text"], | ||
"name": error["code"], | ||
"source": "flake8" | ||
} | ||
|
||
|
||
|
||
|
||
def format_single_linter_file(file_path: str, errors: list) -> dict: | ||
# write your code here | ||
pass | ||
def format_single_linter_file(file_path, errors): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The nested function definition |
||
return { | ||
"errors": [format_linter_error(error) for error in errors], | ||
"path": file_path, | ||
"status": "failed" if errors else "passed" | ||
} | ||
|
||
|
||
|
||
|
||
def format_linter_report(linter_report: dict) -> list: | ||
# write your code here | ||
pass | ||
def format_linter_report(linter_report): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The nested function definition |
||
return [ | ||
format_single_linter_file(file_path, errors) for file_path, errors in linter_report.items() | ||
] | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nested function definition
def format_linter_error(error):
is redundant. The outer function definition already serves the purpose. Consider removing this line.