Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,31 @@
def format_linter_error(error: dict) -> dict:
# write your code here
pass
def format_linter_error(error):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nested function definition def format_linter_error(error): is redundant. The outer function definition already serves the purpose. Consider removing this line.

return {
"line": error["line_number"],
"column": error["column_number"],
"message": error["text"],
"name": error["code"],
"source": "flake8"
}




def format_single_linter_file(file_path: str, errors: list) -> dict:
# write your code here
pass
def format_single_linter_file(file_path, errors):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nested function definition def format_single_linter_file(file_path, errors): is redundant. The outer function definition already serves the purpose. Consider removing this line.

return {
"errors": [format_linter_error(error) for error in errors],
"path": file_path,
"status": "failed" if errors else "passed"
}




def format_linter_report(linter_report: dict) -> list:
# write your code here
pass
def format_linter_report(linter_report):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nested function definition def format_linter_report(linter_report): is redundant. The outer function definition already serves the purpose. Consider removing this line.

return [
format_single_linter_file(file_path, errors) for file_path, errors in linter_report.items()
]


Loading