f #514
Closed
f #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Oct 28, 2023
services/movie.py
Outdated
| return queryset | ||
|
|
||
|
|
||
| def get_movie_by_id(movie_id: int) -> QuerySet[Movie]: |
There was a problem hiding this comment.
It returns one Movie, not queryset
services/movie.py
Outdated
| movie_description: str, | ||
| genres_ids: list[int] = None, | ||
| actors_ids: list[int] = None | ||
| ) -> QuerySet[Movie]: |
services/movie_session.py
Outdated
| movie_show_time: datetime.datetime, | ||
| movie_id: int, | ||
| cinema_hall_id: int | ||
| ) -> QuerySet[MovieSession]: |
vasylhnatiuk
suggested changes
Oct 29, 2023
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('db', '0001_initial'), |
There was a problem hiding this comment.
but theres no need to change migrations. I thought that its better to let django make migrations
Co-authored-by: Vasyl Hnatiuk <[email protected]>
vasylhnatiuk
suggested changes
Oct 29, 2023
db/models.py
Outdated
| title = models.CharField(max_length=255) | ||
| description = models.TextField() | ||
| actors = models.ManyToManyField(Actor, related_name="actors") | ||
| genres = models.ManyToManyField(Genre, related_name="genres") |
db/models.py
Outdated
| class Movie(models.Model): | ||
| title = models.CharField(max_length=255) | ||
| description = models.TextField() | ||
| actors = models.ManyToManyField(Actor, related_name="actors") |
vasylhnatiuk
suggested changes
Oct 29, 2023
db/models.py
Outdated
| class Movie(models.Model): | ||
| title = models.CharField(max_length=255) | ||
| description = models.TextField() | ||
| actors = models.ManyToManyField(Actor) |
There was a problem hiding this comment.
Suggested change
| actors = models.ManyToManyField(Actor) | |
| actors = models.ManyToManyField(Actor, related_name="movies") |
db/models.py
Outdated
| title = models.CharField(max_length=255) | ||
| description = models.TextField() | ||
| actors = models.ManyToManyField(Actor) | ||
| genres = models.ManyToManyField(Genre) |
There was a problem hiding this comment.
Suggested change
| genres = models.ManyToManyField(Genre) | |
| genres = models.ManyToManyField(Genre, related_name="movies") |
There was a problem hiding this comment.
vasylhnatiuk
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.