Resloved #516
Open
Resloved #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasylhnatiuk
suggested changes
Oct 29, 2023
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('db', '0001_initial'), |
services/movie_session.py
Outdated
|
|
||
|
|
||
| def delete_movie_session_by_id(session_id: int) -> None: | ||
| MovieSession.objects.get(id=session_id).delete() |
services/movie_session.py
Outdated
| if show_time: | ||
| session.show_time = show_time | ||
| if movie_id: | ||
| session.movie = Movie.objects.get(id=movie_id) |
vasylhnatiuk
suggested changes
Oct 29, 2023
db/models.py
Outdated
| class Movie(models.Model): | ||
| title = models.CharField(max_length=255) | ||
| description = models.TextField() | ||
| actors = models.ManyToManyField(Actor, related_name="actors", blank=True) |
There was a problem hiding this comment.
db/models.py
Outdated
| title = models.CharField(max_length=255) | ||
| description = models.TextField() | ||
| actors = models.ManyToManyField(Actor, related_name="actors", blank=True) | ||
| genres = models.ManyToManyField(Genre, related_name="genres", blank=True) |
services/cinema_hall.py
Outdated
| from django.db.models import QuerySet | ||
|
|
||
|
|
||
| def get_cinema_halls() -> QuerySet: |
There was a problem hiding this comment.
Suggested change
| def get_cinema_halls() -> QuerySet: | |
| def get_cinema_halls() -> QuerySet[CinemaHall]: |
vsmutok
suggested changes
Oct 29, 2023
services/movie_session.py
Outdated
Comment on lines
36
to
41
| if show_time: | ||
| session.show_time = show_time | ||
| if movie_id: | ||
| session.movie = get_movie_by_id(movie_id) | ||
| if cinema_hall_id: | ||
| session.cinema_hall = get_cinema_halls().get(id=cinema_hall_id) |
There was a problem hiding this comment.
Suggested change
| if show_time: | |
| session.show_time = show_time | |
| if movie_id: | |
| session.movie = get_movie_by_id(movie_id) | |
| if cinema_hall_id: | |
| session.cinema_hall = get_cinema_halls().get(id=cinema_hall_id) | |
| if show_time is not None: | |
| session.show_time = show_time | |
| if movie_id is not None: | |
| session.movie_id = movie_id | |
| if cinema_hall_id is not None: | |
| session.cinema_hall_id = cinema_hall_id |
There was a problem hiding this comment.
It leads to error because we can not assign values directly, he only accepts instance of the classes and I can't find how to pass ids directly. I just can't pass tests with these changes
services/movie_session.py
Outdated
Comment on lines
31
to
33
| show_time: datetime = None, | ||
| movie_id: int = None, | ||
| cinema_hall_id: int = None, |
There was a problem hiding this comment.
Ok, added optional None
|
FAILED tests/test_main.py::test_movie_session_service_update_movie_session_movie - ValueError: Cannot assign "5": "MovieSession.movie" must be a "Movie" instance. |
ArsenPidhoretskyi
suggested changes
Oct 31, 2023
services/movie_session.py
Outdated
Comment on lines
10
to
11
| cinema_hall = CinemaHall.objects.get(id=cinema_hall_id) | ||
| movie = Movie.objects.get(id=movie_id) |
There was a problem hiding this comment.
No need to get objects
You can create objects by id: .create(movie_id=movie_id,.....
services/movie_session.py
Outdated
Comment on lines
18
to
20
| if session_date: | ||
| return MovieSession.objects.filter(show_time__date=session_date) | ||
| return MovieSession.objects.all() |
There was a problem hiding this comment.
Suggested change
| if session_date: | |
| return MovieSession.objects.filter(show_time__date=session_date) | |
| return MovieSession.objects.all() | |
| movie_sessions = MovieSession.objects.all() | |
| if session_date: | |
| return movie_sessions.filter(show_time__date=session_date) | |
| return movie_sessions |
This can help support your code in future
Yurnerroo
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.