implement py-mutable-immutable #2033
Conversation
There was a problem hiding this comment.
Great job on meeting the task requirements and constraints! 🎉 Your code correctly categorizes variables into mutable and immutable types, and the implementation is well-structured. While there was a mention of a logical error in the type checking, the final conclusion indicates that your solution works as intended. Keep up the good work, and continue to pay attention to details like type checking to ensure your code is robust. Well done! 👏
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| ] | ||
|
|
||
| for value in list_all_types: | ||
| if isinstance(value, tuple_immutable): |
There was a problem hiding this comment.
The isinstance function is used incorrectly here. The second argument should be a type or a tuple of types, but tuple_immutable is a tuple of type objects, not types themselves. You should check each element of tuple_immutable individually against value.
No description provided.