Solution #1590
Solution #1590
Conversation
There was a problem hiding this comment.
Great job on implementing the Person class and create_person_list function! 🎉 Your code meets the task requirements and constraints effectively. While there are minor style recommendations, such as using dict.get() for safer dictionary access and list comprehensions for cleaner code, these do not impact the functionality. Keep up the good work and consider these suggestions for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
app/main.py
Outdated
|
|
||
| person_list = [] | ||
|
|
||
| for person_data in people: |
There was a problem hiding this comment.
Consider using list comprehension for creating the person_list to make the code more concise, as recommended in the checklist.
app/main.py
Outdated
|
|
||
| for person_data in people: | ||
| person = Person.people[person_data["name"]] | ||
| if "wife" in person_data and person_data["wife"]: |
There was a problem hiding this comment.
Use person_data.get('wife') instead of checking with in to simplify the code and avoid potential KeyError exceptions, as suggested in the checklist.
app/main.py
Outdated
| person = Person.people[person_data["name"]] | ||
| if "wife" in person_data and person_data["wife"]: | ||
| person.wife = Person.people[person_data["wife"]] | ||
| elif "husband" in person_data and person_data["husband"]: |
There was a problem hiding this comment.
Use person_data.get('husband') instead of checking with in to simplify the code and avoid potential KeyError exceptions, as suggested in the checklist.
|
I've made the changes. |
No description provided.