Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1594

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,26 @@
class Person:
# write your code here
pass
people = {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a class variable people to store instances by name can lead to issues if names are not unique. Consider using a unique identifier or handling potential name collisions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Using names as keys in the people dictionary can cause issues if names are not unique.

Suggestion: Consider using a unique identifier for each person or implement a strategy to handle potential name collisions.


def __init__(self, name: str, age: int) -> None:
self.name = name
self.age = age

def create_person_list(people: list) -> list:
# write your code here
pass
Person.people[name] = self


def create_person_list(people: list[dict]) -> list:
person_list = []

for person_data in people:
person = Person(name=person_data.get("name"),
age=person_data.get("age"))
person_list.append(person)

for person_data in people:
person = Person.people[person_data.get("name")]
if "wife" in person_data and person_data.get("wife"):
person.wife = Person.people[person_data.get("wife")]
if "husband" in person_data and person_data.get("husband"):
person.husband = Person.people[person_data.get("husband")]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code assumes that the 'wife' and 'husband' keys, if present, will always have valid corresponding entries in the people dictionary. This could lead to a KeyError if the specified spouse does not exist. Consider adding a check to ensure the spouse exists in the people dictionary before assigning.


return person_list
Loading