Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,21 @@
class Person:
# write your code here
pass
people = {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The people dictionary is a class variable, which means it is shared across all instances of the Person class. This could lead to unexpected behavior if multiple instances are created with the same name, as they will overwrite each other in the dictionary.


def __init__(self, name: str, age: int) -> None:
self.name = name
self.age = age
Person.people[self.name] = self
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storing the Person instance in the people dictionary using the name as the key assumes that all names are unique. If there are duplicate names, this will cause the previous entry to be overwritten.



def create_person_list(people: list) -> list:
# write your code here
pass
for person in people:
Person(person["name"], person["age"])

for person in people:
select_person = Person.people[person["name"]]
if "wife" in person and person["wife"]:
select_person.wife = Person.people[person["wife"]]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code assumes that the 'wife' is already created and exists in the Person.people dictionary. If the 'wife' is not created before this line is executed, it will raise a KeyError. Consider adding a check to ensure the referenced person exists.

elif "husband" in person and person["husband"]:
select_person.husband = Person.people[person["husband"]]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous comment, this line assumes that the 'husband' is already created and exists in the Person.people dictionary. A KeyError will be raised if the 'husband' is not present. Consider adding a check to handle this case.


return list(Person.people.values())
Loading