Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first solution. all tests passed. flake8 app passed #1613

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

first solution. all tests passed. flake8 app passed #1613

wants to merge 2 commits into from

Conversation

Mykola-Osolinskyi
Copy link

No description provided.

Nattalli
Nattalli suggested changes Dec 9, 2024
View reviewed changes
app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated
person = Person(person_inf["name"], person_inf["age"])
persons.append(person)

for person_inf in people:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for person_inf in people:
for person in people:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or

Suggested change
for person_inf in people:
for person_data in people:

Nattalli
Nattalli approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@Nattalli Nattalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nattalli Nattalli Nattalli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mykola-Osolinskyi @Nattalli