solution #1635
solution #1635
Conversation
There was a problem hiding this comment.
Great job on implementing the Person class and the create_person_list function! 🎉 Your code meets most of the task requirements and constraints. While there are a few minor issues related to dictionary access, list comprehension, and the handling of relationships, these do not significantly impact the functionality. Keep up the good work, and consider the feedback for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1,8 +1,23 @@ | |||
| class Person: | |||
| # write your code here | |||
| pass | |||
| people = {} | |||
There was a problem hiding this comment.
Using a class-level dictionary people to store instances by name can lead to issues if multiple people have the same name. Consider using unique identifiers for each person.
| person_instance.wife = Person.people[person["wife"]] | ||
| elif "husband" in person and person["husband"] is not None: | ||
| person_instance.husband = Person.people[person["husband"]] |
There was a problem hiding this comment.
The code assumes that the spouse (wife/husband) is already created and present in the Person.people dictionary. Ensure that the input list people is ordered or structured such that all referenced spouses are created before they are assigned.
No description provided.