Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1640

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,29 @@
class Person:
# write your code here
pass

people = {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The people dictionary is used to store Person instances by name. This could lead to issues if names are not unique, as it will overwrite existing entries with the same name. Consider using a different key or structure to ensure uniqueness.


def create_person_list(people: list) -> list:
# write your code here
pass
def __init__(self, name: str, age: int) -> None:
self.name = name
self.age = age
Person.people[name] = self


def create_person_list(people_list: list) -> list:

person_instances = []
for person_data in people_list:
name = person_data.get("name")
age = person_data.get("age")
person = Person(name, age)
person_instances.append(person)

for person_data in people_list:
name = person_data.get("name")
current_person = Person.people[name]

if "wife" in person_data and person_data["wife"]:
current_person.wife = Person.people[person_data["wife"]]
if "husband" in person_data and person_data["husband"]:
current_person.husband = Person.people[person_data["husband"]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code attempts to set wife and husband attributes on Person instances, but these attributes are not defined in the Person class. This will result in an AttributeError if accessed later. Consider defining these attributes in the Person class, perhaps initializing them to None.


return person_instances
Loading