-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1640
base: master
Are you sure you want to change the base?
Solution #1640
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,29 @@ | ||
class Person: | ||
# write your code here | ||
pass | ||
|
||
people = {} | ||
|
||
def create_person_list(people: list) -> list: | ||
# write your code here | ||
pass | ||
def __init__(self, name: str, age: int) -> None: | ||
self.name = name | ||
self.age = age | ||
Person.people[name] = self | ||
|
||
|
||
def create_person_list(people_list: list) -> list: | ||
|
||
person_instances = [] | ||
for person_data in people_list: | ||
name = person_data.get("name") | ||
age = person_data.get("age") | ||
person = Person(name, age) | ||
person_instances.append(person) | ||
|
||
for person_data in people_list: | ||
name = person_data.get("name") | ||
current_person = Person.people[name] | ||
|
||
if "wife" in person_data and person_data["wife"]: | ||
current_person.wife = Person.people[person_data["wife"]] | ||
if "husband" in person_data and person_data["husband"]: | ||
current_person.husband = Person.people[person_data["husband"]] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code attempts to set |
||
|
||
return person_instances |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
people
dictionary is used to storePerson
instances by name. This could lead to issues if names are not unique, as it will overwrite existing entries with the same name. Consider using a different key or structure to ensure uniqueness.