-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Person #1641
Open
ProgrammerYaroslav
wants to merge
26
commits into
mate-academy:python-add-person-class
Choose a base branch
from
ProgrammerYaroslav:master
base: python-add-person-class
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Person #1641
ProgrammerYaroslav
wants to merge
26
commits into
mate-academy:python-add-person-class
from
ProgrammerYaroslav:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-class Python add person class github task
…n-class Edited
…upd_flake add exclude venv and tests in .flake8
add timeout on tests
…x-readme upd tests and `README.md`
add tests and checklist
…eadme update README.md and checklist.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@@ -9,13 +9,19 @@ a person, it has keys:
name
,age
,female. All
names
are different. Keywife
/husband
can be eitherNone
orname of another person.
Define a Class
Person
The
__init__
method should take two parametersname
: A string representing the name of the person.age
: An integer representing the age of the person.Create class
Person
. It's constructor takesand store
name
,age
of a person.This class also should have a class attribute
people
, it is a dict that storesPerson
instances by their
name
. Constructor shouldadd elements to this attribute.
3. Define a class attribute
people
in thePerson
class to store instances by theirname
.- The keys are the
name
values of instances.- The values are references to the
Person
instances themselves.- Within the
__init__
method, add each newPerson
instance to thepeople
dictionary.Write function
create_person_list
, this functiontakes list
people
and return list withchecklist.md
+15
-3
Original file line number Diff line number Diff line change
@@ -18,8 +18,20 @@ def get_full_name(x: str, y: str) -> str:
Add comments, prints, and functions to check your solution when you write your code.
Don't forget to delete them when you are ready to commit and push your code.
Bad example:
Clean Code
There is no need to add comments to the code as it is clear and self-explanatory.