'Solution' #1661
'Solution' #1661
Conversation
There was a problem hiding this comment.
Great job on implementing the Person class and the create_person_list function! 🎉 Your code meets the task requirements and constraints effectively. There are just a couple of minor improvements you could consider for future projects: using list comprehension for creating persons_list and accessing the people dictionary with Person.people instead of self.people. These changes will enhance the code's efficiency and correctness. Keep up the great work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __init__(self, name: str, age: int) -> None: | ||
| self.name = name | ||
| self.age = age | ||
| self.people.update({self.name: self}) |
There was a problem hiding this comment.
In the __init__ method, the people dictionary should be accessed using Person.people instead of self.people. This ensures that the class attribute is updated correctly. Change self.people.update({self.name: self}) to Person.people.update({self.name: self}).
| persons_list = [] | ||
| for person in people: | ||
| persons_list.append(Person(person["name"], person["age"])) |
There was a problem hiding this comment.
Consider using list comprehension to create persons_list as recommended in the checklist. This will make the code more concise and efficient. For example: persons_list = [Person(person['name'], person['age']) for person in people].
No description provided.