Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement py-person-class #1667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,23 @@
class Person:
# write your code here
pass
people = {}

def __init__(self, name: str, age: int) -> None:
self.name = name
self.age = age
Person.people[name] = self


def create_person_list(people: list) -> list:
# write your code here
pass
result_list = [Person(name=person["name"], age=person["age"])
for person in people]
Comment on lines +11 to +12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list comprehension correctly creates Person instances, but ensure that the input list people contains dictionaries with the keys name and age to avoid KeyError.


for person in people:
if person.get("wife"):
main_person = Person.people[person["name"]]
wife_person = Person.people[person["wife"]]
Comment on lines +16 to +17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before accessing Person.people[person['wife']], ensure that the wife exists in the people dictionary to avoid a potential KeyError.

main_person.wife = wife_person
elif person.get("husband"):
main_person = Person.people[person["name"]]
husband_person = Person.people[person["husband"]]
Comment on lines +20 to +21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, before accessing Person.people[person['husband']], ensure that the husband exists in the people dictionary to avoid a potential KeyError.

main_person.husband = husband_person
return result_list
Loading