Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,20 @@
class Person:
# write your code here
pass

people = {}

def __init__(self, name: str, age: int) -> None:
self.name = name
self.age = age
Person.people[self.name] = self


def create_person_list(people: list) -> list:
# write your code here
pass
result = [Person(person["name"], person["age"]) for person in people]

for i, person in enumerate(people):
if person.get("wife") is not None:
result[i].wife = Person.people.get(person["wife"])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a potential issue here if person['wife'] does not exist in Person.people. The get method will return None, which might not be the intended behavior. Consider adding a check or handling for this case.

if person.get("husband") is not None:
result[i].husband = Person.people.get(person["husband"])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous comment, if person['husband'] does not exist in Person.people, None will be assigned to result[i].husband. Ensure this is the desired behavior or add handling for this case.


return result
Loading