Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,25 @@
class Person:
# write your code here
pass
people = {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The people dictionary is defined as a class attribute. Ensure that this is intended, as it will store all instances of Person by name across all instances. If this is not the desired behavior, consider using an instance attribute instead.


def __init__(self, name: str, age: int) -> None:
self.name = name
self.age = age
Person.people[name] = self

def create_person_list(people: list) -> list:
# write your code here
pass

def create_person_list(people_dicts: list) -> list:
person_list = []
for person_dict in people_dicts:
person = Person(name=person_dict["name"], age=person_dict["age"])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Person class constructor is called with name and age keys from the dictionary. Ensure that all dictionaries in people_dicts contain these keys to avoid KeyError exceptions.

person_list.append(person)

for person_dict in people_dicts:
name = person_dict["name"]
instance = Person.people[name]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing Person.people[name] assumes that every name in people_dicts has been added to the people dictionary. Ensure that all names are unique and have been initialized to avoid KeyError exceptions.


if "wife" in person_dict and person_dict["wife"]:
instance.wife = Person.people[person_dict["wife"]]
elif "husband" in person_dict and person_dict["husband"]:
instance.husband = Person.people[person_dict["husband"]]
Comment on lines +21 to +23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code assumes that the wife or husband keys in person_dict refer to existing Person instances. Ensure that these relationships are correctly defined in people_dicts to avoid KeyError exceptions.


return person_list
Loading