-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1696
base: master
Are you sure you want to change the base?
Solution #1696
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,25 @@ | ||
class Person: | ||
# write your code here | ||
pass | ||
people = {} | ||
|
||
def __init__(self, name: str, age: int) -> None: | ||
self.name = name | ||
self.age = age | ||
Person.people[name] = self | ||
|
||
def create_person_list(people: list) -> list: | ||
# write your code here | ||
pass | ||
|
||
def create_person_list(people_dicts: list) -> list: | ||
person_list = [] | ||
for person_dict in people_dicts: | ||
person = Person(name=person_dict["name"], age=person_dict["age"]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
person_list.append(person) | ||
|
||
for person_dict in people_dicts: | ||
name = person_dict["name"] | ||
instance = Person.people[name] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accessing |
||
|
||
if "wife" in person_dict and person_dict["wife"]: | ||
instance.wife = Person.people[person_dict["wife"]] | ||
elif "husband" in person_dict and person_dict["husband"]: | ||
instance.husband = Person.people[person_dict["husband"]] | ||
Comment on lines
+21
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code assumes that the |
||
|
||
return person_list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
people
dictionary is defined as a class attribute. Ensure that this is intended, as it will store all instances ofPerson
by name across all instances. If this is not the desired behavior, consider using an instance attribute instead.