Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1699

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 44 additions & 8 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,44 @@
class Person:
# write your code here
pass


def create_person_list(people: list) -> list:
# write your code here
pass
class Person:
people = {}

def __init__(self, name: str, age: int) -> None:
self.name = name
self.age = age
Person.people[name] = self

def set_spouse(self, spouse_name: str, gender: str) -> None:
spouse = Person.people.get(spouse_name)

if gender == "male" and spouse:
self.husband = spouse
spouse.wife = self
elif gender == "female" and spouse:
self.wife = spouse
spouse.husband = self

Comment on lines +12 to +17
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here assumes that the gender is determined by the presence of 'husband' or 'wife' in the data. This might not be accurate if the data structure changes or if the gender is explicitly provided. Consider revising the logic to handle gender more explicitly or based on additional data.


def create_person_list(people: list) -> list:
person_list = []

for person_data in people:
name = person_data["name"]
age = person_data["age"]

# Create a new Person instance
person = Person(name, age)

# Determine the spouse and gender
spouse_name = (
person_data.get("wife") or person_data.get("husband")
)

gender = "male" if "husband" in person_data else "female"
if spouse_name:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gender determination logic assumes that the presence of 'husband' indicates a male and 'wife' indicates a female. This might not be accurate if the data structure changes or if the gender is explicitly provided. Consider revising the logic to handle gender more explicitly or based on additional data.

person.set_spouse(
spouse_name,
gender
)

person_list.append(person)

return person_list
292 changes: 146 additions & 146 deletions tests/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,146 +1,146 @@
import ast
import os

import pytest

from app.main import create_person_list
from app.main import Person


def path_to_main():
base_path = os.path.join("app", "main.py")
return (
base_path if os.path.exists(base_path) else os.path.join(os.pardir, base_path)
)


@pytest.fixture()
def people_data():
return [
{"name": "Ross", "age": 30, "wife": "Rachel"},
{"name": "Joey", "age": 29, "wife": None},
{"name": "Phoebe", "age": 31, "husband": None},
{"name": "Chandler", "age": 30, "wife": "Monica"},
{"name": "Monica", "age": 32, "husband": "Chandler"},
{"name": "Rachel", "age": 28, "husband": "Ross"},
]


@pytest.fixture()
def created_person_list(people_data):
return create_person_list(people_data)


def test_person_class_attribute_people_exists():
assert hasattr(
Person, "people"
), "Class Person should have class attribute 'people'"
assert (
len(Person.people) == 0
), "Initial length of 'Person.people' should equal to 0"


@pytest.mark.parametrize("name,age", [("Ross", 30), ("Joey", 29)])
def test_person_class_name_age(name, age):
person_inst = Person(name, age)
assert person_inst.name == name, "Person instance should have attribute 'name'"
assert person_inst.age == age, "Person instance should have attribute 'age'"


def test_create_person_list_all_persons(people_data, created_person_list):
assert all(isinstance(person, Person) for person in created_person_list), (
"All elements in result of 'create_person_list' should be instance "
"of Person class"
)
assert len(created_person_list) == len(
people_data
), "Length of initial list should equal to length of function result"


def test_create_person_list_order(people_data, created_person_list):
assert [person_dict["name"] for person_dict in people_data] == [
person.name for person in created_person_list
], "Order in function result should be the same"


def test_create_person_list_has_wife(people_data, created_person_list):
assert hasattr(created_person_list[0], "wife"), (
f"Person with 'name' {created_person_list[0].name} should have "
f"attribute 'wife' with name {people_data[0].wife.name}"
)


def test_create_person_list_has_wife_and_wife_have_husband(
people_data, created_person_list
):
assert (
hasattr(created_person_list[0], "wife")
and created_person_list[0].wife.husband == created_person_list[0]
), (
f"Person with 'name' {created_person_list[0].name} should have "
f"attribute 'wife' with name {created_person_list[0].wife.name} and "
f"Person.wife.husband should links to that Person"
)


def test_create_person_list_has_no_wife(people_data, created_person_list):
assert hasattr(created_person_list[1], "wife") is False, (
f"Person with 'name' {created_person_list[1].name} should not have "
f"attribute wife"
)


def test_person_class_attribute_people(people_data, created_person_list):
assert all(
isinstance(person, Person) for person in Person.people.values()
), "All elements of Person class attribute 'people' should be Person instances"
assert len(Person.people) == len(
people_data
), "Length of Person class attribute people should be equal to length of initial list"


def test_create_person_list_returns_only_entering_people(
people_data, created_person_list
):
assert len(people_data) == len(
created_person_list
), "Length of passed list should equal to length of returned list"
assert [person["name"] for person in people_data] == [
person.name for person in created_person_list
], (
"People, that are passed to the function should equal to people, "
"that are returned"
)


def test_person_instance_attribute_wife_and_husband_doesnt_exists():
with open(path_to_main()) as file:
tree = ast.parse(file.read())

assert (
len(
tree.__dict__["body"][0]
.__dict__["body"][1]
.__dict__["args"]
.__dict__["args"]
)
== 3
), "'__init__' should takes only two arguments 'name' and 'age'!"


def test_removed_comment():
with open(path_to_main(), "r") as file:
main_content = file.read()

assert (
"# write your code here" not in main_content
), "You have to remove the unnecessary comment '# write your code here'"


def test_double_quotes_instead_of_single():
with open(path_to_main(), "r") as file:
main_content = file.read()

assert (
"'" not in main_content
), "You have to use a double quotes \"\" instead of single ''"
import ast
import os
import pytest
from app.main import create_person_list
from app.main import Person
def path_to_main():
base_path = os.path.join("app", "main.py")
return (
base_path if os.path.exists(base_path) else os.path.join(os.pardir, base_path)
)
@pytest.fixture()
def people_data():
return [
{"name": "Ross", "age": 30, "wife": "Rachel"},
{"name": "Joey", "age": 29, "wife": None},
{"name": "Phoebe", "age": 31, "husband": None},
{"name": "Chandler", "age": 30, "wife": "Monica"},
{"name": "Monica", "age": 32, "husband": "Chandler"},
{"name": "Rachel", "age": 28, "husband": "Ross"},
]
@pytest.fixture()
def created_person_list(people_data):
return create_person_list(people_data)
def test_person_class_attribute_people_exists():
assert hasattr(
Person, "people"
), "Class Person should have class attribute 'people'"
assert (
len(Person.people) == 0
), "Initial length of 'Person.people' should equal to 0"
@pytest.mark.parametrize("name,age", [("Ross", 30), ("Joey", 29)])
def test_person_class_name_age(name, age):
person_inst = Person(name, age)
assert person_inst.name == name, "Person instance should have attribute 'name'"
assert person_inst.age == age, "Person instance should have attribute 'age'"
def test_create_person_list_all_persons(people_data, created_person_list):
assert all(isinstance(person, Person) for person in created_person_list), (
"All elements in result of 'create_person_list' should be instance "
"of Person class"
)
assert len(created_person_list) == len(
people_data
), "Length of initial list should equal to length of function result"
def test_create_person_list_order(people_data, created_person_list):
assert [person_dict["name"] for person_dict in people_data] == [
person.name for person in created_person_list
], "Order in function result should be the same"
def test_create_person_list_has_wife(people_data, created_person_list):
assert hasattr(created_person_list[0], "wife"), (
f"Person with 'name' {created_person_list[0].name} should have "
f"attribute 'wife' with name {people_data[0].wife.name}"
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test assumes that the 'wife' attribute is always present and accessible. This might not be the case if the logic in main.py changes or if the data structure is different. Consider adding checks to ensure the attribute exists before accessing it.

def test_create_person_list_has_wife_and_wife_have_husband(
people_data, created_person_list
):
assert (
hasattr(created_person_list[0], "wife")
and created_person_list[0].wife.husband == created_person_list[0]
), (
f"Person with 'name' {created_person_list[0].name} should have "
f"attribute 'wife' with name {created_person_list[0].wife.name} and "
f"Person.wife.husband should links to that Person"
)
Comment on lines +81 to +82
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test assumes that the 'wife' and 'husband' attributes are always set correctly. This might not hold true if the logic in main.py changes. Consider adding checks to ensure these attributes are set as expected.

def test_create_person_list_has_no_wife(people_data, created_person_list):
assert hasattr(created_person_list[1], "wife") is False, (
f"Person with 'name' {created_person_list[1].name} should not have "
f"attribute wife"
)
Comment on lines +88 to +89
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test assumes that the 'wife' attribute should not exist for certain instances. Ensure that the logic in main.py aligns with this assumption, as changes in the main logic might affect this test.

def test_person_class_attribute_people(people_data, created_person_list):
assert all(
isinstance(person, Person) for person in Person.people.values()
), "All elements of Person class attribute 'people' should be Person instances"
assert len(Person.people) == len(
people_data
), "Length of Person class attribute people should be equal to length of initial list"
def test_create_person_list_returns_only_entering_people(
people_data, created_person_list
):
assert len(people_data) == len(
created_person_list
), "Length of passed list should equal to length of returned list"
assert [person["name"] for person in people_data] == [
person.name for person in created_person_list
], (
"People, that are passed to the function should equal to people, "
"that are returned"
)
def test_person_instance_attribute_wife_and_husband_doesnt_exists():
with open(path_to_main()) as file:
tree = ast.parse(file.read())
assert (
len(
tree.__dict__["body"][0]
.__dict__["body"][1]
.__dict__["args"]
.__dict__["args"]
)
== 3
), "'__init__' should takes only two arguments 'name' and 'age'!"
def test_removed_comment():
with open(path_to_main(), "r") as file:
main_content = file.read()
assert (
"# write your code here" not in main_content
), "You have to remove the unnecessary comment '# write your code here'"
def test_double_quotes_instead_of_single():
with open(path_to_main(), "r") as file:
main_content = file.read()
assert (
"'" not in main_content
), "You have to use a double quotes \"\" instead of single ''"
Loading