Solution #807
Open
Solution #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdAlekseiev
suggested changes
Oct 17, 2023
app/main.py
Outdated
Comment on lines
13
to
16
| person_list = [] | ||
|
|
||
| for dc in people: | ||
| _ = Person(dc["name"], dc["age"]) |
app/main.py
Outdated
Comment on lines
20
to
21
| if "wife" in dc: | ||
| if dc["wife"] is not None: |
There was a problem hiding this comment.
Suggested change
| if "wife" in dc: | |
| if dc["wife"] is not None: | |
| if dc.get("wife"): |
app/main.py
Outdated
Comment on lines
24
to
25
| if "husband" in dc: | ||
| if dc["husband"] is not None: |
There was a problem hiding this comment.
Suggested change
| if "husband" in dc: | |
| if dc["husband"] is not None: | |
| if dc.get("husband"): |
EdAlekseiev
suggested changes
Oct 20, 2023
app/main.py
Outdated
Comment on lines
12
to
14
| person_list = [] | ||
|
|
||
| _ = [Person(dc["name"], dc["age"]) for dc in people] |
There was a problem hiding this comment.
Suggested change
| person_list = [] | |
| _ = [Person(dc["name"], dc["age"]) for dc in people] | |
| person_list = [Person(dc["name"], dc["age"]) for dc in people] |
There was a problem hiding this comment.
when i try this way in the end of test person_list has 2 copies for each Person
There was a problem hiding this comment.
If you delete person_list.append(Person.people[dc["name"]]) in 25 line, you will not have duplicates in person_list
app/main.py
Outdated
Comment on lines
27
to
28
| for i in person_list: | ||
| print(i.name) |
EdAlekseiev
suggested changes
Oct 23, 2023
app/main.py
Outdated
Comment on lines
12
to
14
| person_list = [] | ||
|
|
||
| _ = [Person(dc["name"], dc["age"]) for dc in people] |
There was a problem hiding this comment.
If you delete person_list.append(Person.people[dc["name"]]) in 25 line, you will not have duplicates in person_list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.