Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #811

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

'Solution' #811

wants to merge 3 commits into from

Conversation

Olala2104
Copy link

No description provided.

Copy link

@Grayder0152 Grayder0152 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix tests

app/main.py Outdated
Comment on lines 22 to 23
spouse_name: Optional[str] = \
person_data.get("wife") or person_data.get("husband")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use () instead of \

app/main.py Outdated
Comment on lines 25 to 26
spouse: Optional[Person] = Person.people.get(spouse_name) \
if spouse_name else None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use () instead of \

Comment on lines +7 to +9
def __init__(self, name: str,
age: int,
spouse: Optional["Person"] = None) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Olala2104
Copy link
Author

ok

@Olala2104 Olala2104 requested a review from Grayder0152 October 26, 2023 15:32
Copy link

@vasylhnatiuk vasylhnatiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants