Develop #819
Open
Develop #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polyakiv-Andrey
suggested changes
Oct 24, 2023
| person_list.append(person) | ||
|
|
||
| for ind, spouses in enumerate(people): | ||
| if "wife" in spouses and spouses["wife"] is not None: |
There was a problem hiding this comment.
is not None should be omitted, it will work without it
There was a problem hiding this comment.
I don't think so:
people = [{'age': 30, 'name': 'Ross', 'wife': 'Rachel'}, {'age': 29, 'name': 'Joey', 'wife': None}, ...
Without this additional condition, I don't pass the pytests.
| wife = Person.people.get(spouses["wife"]) | ||
| person_list[ind].wife = wife | ||
| wife.husband = person_list[ind] | ||
| if "husband" in spouses and spouses["husband"] is not None: |
There was a problem hiding this comment.
is not None should be omitted, it will work without it
app/main.py
Outdated
| def __init__(self, name: str, age: int) -> None: | ||
| self.name = name | ||
| self.age = age | ||
| Person.people.setdefault(name, self) | ||
|
|
||
|
|
||
| def create_person_list(people: list) -> list: |
There was a problem hiding this comment.
add more detail type annotation for list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.