Solution #828
Open
Solution #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktoria-rybenchuk
suggested changes
Oct 28, 2023
app/main.py
Outdated
Comment on lines
12
to
17
| result = [] | ||
|
|
||
| for item in people: | ||
| person = Person(name=item["name"], age=item["age"]) | ||
| married_dict[item["name"]] = person | ||
| result.append(person) |
There was a problem hiding this comment.
Consider using a list comprehension for a more concise approach
app/main.py
Outdated
|
|
||
|
|
||
| def create_person_list(people: list) -> list: | ||
| # write your code here | ||
| pass | ||
| married_dict = {} |
There was a problem hiding this comment.
why do you need this dict?
There was a problem hiding this comment.
to make a connection between married people
app/main.py
Outdated
| married_dict[item["name"]] = person | ||
| result.append(person) | ||
|
|
||
| for item in people: |
There was a problem hiding this comment.
Consider using person instead of item for clarity
app/main.py
Outdated
| result.append(person) | ||
|
|
||
| for item in people: | ||
| person_obj = married_dict[item["name"]] |
There was a problem hiding this comment.
You can create a variable for 'person' and then use it, instead of adding it to the dictionary
viktoria-rybenchuk
suggested changes
Oct 28, 2023
app/main.py
Outdated
Comment on lines
14
to
15
| Person.people.get(person["name"]).wife = \ | ||
| Person.people.get(person["wife"]) |
There was a problem hiding this comment.
you can avoid using a backslash by breaking the code into multiple lines using parentheses to indicate a continuation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.