Solution 27102023 #829
Open
Solution 27102023 #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdAlekseiev
suggested changes
Oct 28, 2023
app/main.py
Outdated
Comment on lines
13
to
18
| for pers in people1: | ||
| pers_inst = Person(pers["name"], pers["age"]) | ||
| if "wife" in pers and pers["wife"] is not None: | ||
| pers_inst.wife = pers["wife"] | ||
| elif "husband" in pers and pers["husband"] is not None: | ||
| pers_inst.husband = pers["husband"] |
There was a problem hiding this comment.
Firstly, you need just create all instances of Person without assign a husband and a wife. You can add the created instances to output_list. And the last, you can use a list comprehension instead of the loop.
app/main.py
Outdated
Comment on lines
13
to
18
| for pers in people1: | ||
| pers_inst = Person(pers["name"], pers["age"]) | ||
| if "wife" in pers and pers["wife"] is not None: | ||
| pers_inst.wife = pers["wife"] | ||
| elif "husband" in pers and pers["husband"] is not None: | ||
| pers_inst.husband = pers["husband"] |
There was a problem hiding this comment.
Suggested change
| for pers in people1: | |
| pers_inst = Person(pers["name"], pers["age"]) | |
| if "wife" in pers and pers["wife"] is not None: | |
| pers_inst.wife = pers["wife"] | |
| elif "husband" in pers and pers["husband"] is not None: | |
| pers_inst.husband = pers["husband"] | |
| for pers in people1: | |
| pers_inst = Person(pers["name"], pers["age"]) | |
| output_list.append(pers_inst) |
app/main.py
Outdated
Comment on lines
21
to
22
| Person.people[pers1].wife =\ | ||
| Person.people[Person.people[pers1].wife] |
There was a problem hiding this comment.
Use () instead of \for separating lines
app/main.py
Outdated
Comment on lines
24
to
25
| Person.people[pers1].husband =\ | ||
| Person.people[Person.people[pers1].husband] |
There was a problem hiding this comment.
Use () instead of \for separating lines
|
Eduard, please see new version |
EdAlekseiev
suggested changes
Oct 30, 2023
app/main.py
Outdated
Comment on lines
17
to
20
| if "wife" in pers and pers["wife"] is not None: | ||
| output_list[-1].wife = pers["wife"] | ||
| elif "husband" in pers and pers["husband"] is not None: | ||
| output_list[-1].husband = pers["husband"] |
There was a problem hiding this comment.
You don't need to do in there, make it in second loop
|
Eduard, please see the last version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.