Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #839

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Solution #839

wants to merge 4 commits into from

Conversation

Vityk-4W
Copy link

@Vityk-4W Vityk-4W commented Nov 5, 2023

No description provided.

YukihiroSM
YukihiroSM suggested changes Nov 5, 2023
View reviewed changes
app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
@Vityk-4W Vityk-4W requested a review from YukihiroSM November 5, 2023 20:06
@Vityk-4W
Copy link
Author

Vityk-4W commented Nov 6, 2023

Fixed

ArsenPidhoretskyi
ArsenPidhoretskyi suggested changes Nov 6, 2023
View reviewed changes
app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
@Vityk-4W
Copy link
Author

Vityk-4W commented Nov 6, 2023

Fixed. I used list comprehension and simplified the condition.

EdAlekseiev
EdAlekseiev suggested changes Nov 7, 2023
View reviewed changes
app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
@Vityk-4W
Copy link
Author

Vityk-4W commented Nov 7, 2023

Ok. I fixed all ["if person.get("wife/husband"):] lines.

@Vityk-4W Vityk-4W requested a review from EdAlekseiev November 9, 2023 22:24
EdAlekseiev
EdAlekseiev approved these changes Nov 10, 2023
View reviewed changes
Copy link

@EdAlekseiev EdAlekseiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdAlekseiev EdAlekseiev EdAlekseiev approved these changes

@YukihiroSM YukihiroSM Awaiting requested review from YukihiroSM

@ArsenPidhoretskyi ArsenPidhoretskyi Awaiting requested review from ArsenPidhoretskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vityk-4W @YukihiroSM @ArsenPidhoretskyi @EdAlekseiev