Develop #849
Open
Develop #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdAlekseiev
suggested changes
Nov 14, 2023
app/main.py
Outdated
Comment on lines
12
to
15
| out = [] | ||
|
|
||
| for person in people: | ||
| out.append(Person(person["name"], person["age"])) |
app/main.py
Outdated
| for person in people: | ||
| out.append(Person(person["name"], person["age"])) | ||
|
|
||
| all_p = Person.people |
There was a problem hiding this comment.
It's a redundant variable, you can use just Person.people
app/main.py
Outdated
Comment on lines
20
to
24
| if ("wife" in data) and (data["wife"] is not None): | ||
| out[i].wife = all_p[data["wife"]] | ||
|
|
||
| if ("husband" in data) and (data["husband"] is not None): | ||
| out[i].husband = all_p[data["husband"]] |
There was a problem hiding this comment.
Suggested change
| if ("wife" in data) and (data["wife"] is not None): | |
| out[i].wife = all_p[data["wife"]] | |
| if ("husband" in data) and (data["husband"] is not None): | |
| out[i].husband = all_p[data["husband"]] | |
| if data.get("wife"):: | |
| out[i].wife = all_p[data["wife"]] | |
| if data.get("husband"): | |
| out[i].husband = all_p[data["husband"]] |
app/main.py
Outdated
| if ("husband" in data) and (data["husband"] is not None): | ||
| out[i].husband = all_p[data["husband"]] | ||
|
|
||
| print("out", out) |
|
|
EdAlekseiev
suggested changes
Nov 15, 2023
app/main.py
Outdated
Comment on lines
12
to
13
| out = [] | ||
| [out.append(Person(person["name"], person["age"])) for person in people] |
There was a problem hiding this comment.
Suggested change
| out = [] | |
| [out.append(Person(person["name"], person["age"])) for person in people] | |
| out = [Person(person["name"], person["age"]) for person in people] |
|
Hi, How can i fix this error in code |
That's not an error, that's just Pycharm can't recognize the wife attribute of the object. That might be ignored in this case. |
|
ok. i understand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.