Solution #855
Open
Solution #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Nov 17, 2023
app/main.py
Outdated
| elif "husband" in person and person["husband"] is not None: | ||
| Person.people[person["name"]].husband = Person.people[person["husband"]] | ||
|
|
||
| return list(Person.people.values()) |
There was a problem hiding this comment.
But if we two times run this function we should expect only people from people_list
app/main.py
Outdated
| Person(person["name"], person["age"]) | ||
|
|
||
| for person in people_list: | ||
| if "wife" in person and person["wife"] is not None: |
There was a problem hiding this comment.
use .get instead of 2 conditions
vsmutok
suggested changes
Jan 20, 2024
app/main.py
Outdated
| pass | ||
|
|
||
| def create_person_list(people_list: list) -> list: | ||
| Person.people.clear() |
app/main.py
Outdated
Comment on lines
12
to
13
| for person in people_list: | ||
| Person(person["name"], person["age"]) |
There was a problem hiding this comment.
people = [Person (person["name"], person["age"]) for person in people_list]
app/main.py
Outdated
| else: | ||
| person_instance.husband = Person.people[spouse_name] | ||
|
|
||
| return list(Person.people.values()) |
There was a problem hiding this comment.
Suggested change
| return list(Person.people.values()) | |
| return people |
ArsenPidhoretskyi
suggested changes
Feb 8, 2024
Co-authored-by: ArsenPidhoretskyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.