Solution #856
Open
Solution #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Nov 19, 2023
app/main.py
Outdated
Comment on lines
12
to
26
| for person in people: | ||
| person_list = Person(person["name"], person["age"]) | ||
| if "wife" in person and person["wife"] is not None: | ||
| wife_name = person["wife"] | ||
| if wife_name in Person.people: | ||
| person_list.wife = Person.people[wife_name] | ||
| Person.people[wife_name].husband = person_list | ||
|
|
||
| elif "husband" in person and person["husband"] is not None: | ||
| husband_name = person["husband"] | ||
| if husband_name in Person.people: | ||
| person_list.husband = Person.people[husband_name] | ||
| Person.people[husband_name].wife = person_list | ||
|
|
||
| person_instances.append(person_list) |
There was a problem hiding this comment.
Better to use two loops. One for creating people instances, second for setting wife/husband
app/main.py
Outdated
| person_instances = [] | ||
| for person in people: | ||
| person_list = Person(person["name"], person["age"]) | ||
| if "wife" in person and person["wife"] is not None: |
There was a problem hiding this comment.
Instead of and statement use .get
EdAlekseiev
suggested changes
Nov 20, 2023
app/main.py
Outdated
Comment on lines
11
to
14
| person_instances = [] | ||
| for person in people: | ||
| person_list = Person(person["name"], person["age"]) | ||
| person_instances.append(person_list) |
app/main.py
Outdated
Comment on lines
17
to
28
| person_list = Person.people[person["name"]] | ||
| right_name = person.get("wife") or person.get("husband") | ||
|
|
||
| if right_name is not None: | ||
| if right_name in Person.people: | ||
| spouse_instance = Person.people[right_name] | ||
| if "wife" in person: | ||
| person_list.wife = spouse_instance | ||
| spouse_instance.husband = person_list | ||
| elif "husband" in person: | ||
| person_list.husband = spouse_instance | ||
| spouse_instance.wife = person_list |
There was a problem hiding this comment.
This code looks difficult to understand, you have to simplify it
Suggested change
| person_list = Person.people[person["name"]] | |
| right_name = person.get("wife") or person.get("husband") | |
| if right_name is not None: | |
| if right_name in Person.people: | |
| spouse_instance = Person.people[right_name] | |
| if "wife" in person: | |
| person_list.wife = spouse_instance | |
| spouse_instance.husband = person_list | |
| elif "husband" in person: | |
| person_list.husband = spouse_instance | |
| spouse_instance.wife = person_list | |
| person_list = Person.people[person["name"]] | |
| if person_list.get("wife"): | |
| person_list.wife = Person.people[person["wife"]] | |
| if person_list.get("husband"): | |
| person_list. husband = Person.people[person["husband"]] |
EdAlekseiev
approved these changes
Nov 21, 2023
Comment on lines
+11
to
+12
| p_inst = [] | ||
| [p_inst.append(Person(person["name"], person["age"])) for person in people] |
There was a problem hiding this comment.
Suggested change
| p_inst = [] | |
| [p_inst.append(Person(person["name"], person["age"])) for person in people] | |
| p_inst = [Person(person["name"], person["age"]) for person in people] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.