Solution #879
Solution #879
Conversation
app/main.py
Outdated
| for person in people: | ||
| person1 = Person(person["name"], person["age"]) | ||
|
|
||
| if "wife" in person and person["wife"]: |
app/main.py
Outdated
| person1.wife = Person.people[person["name"]] | ||
| Person.people[person["name"]].husband = person1 | ||
|
|
||
| if "husband" in person and person["husband"]: |
README.md
Outdated
| and store `name`, `age` of a person. | ||
| This class also should have a class attribute | ||
| `people`, it is a dict that stores `Person` | ||
| instances by their `name`. Constructor should | ||
| instances by their `name`. The `__init__` method should |
There was a problem hiding this comment.
i didnt change that. I think it it was IDE when i set up this project. should i fix this?
There was a problem hiding this comment.
Yes, remove this file from the PR, please. Only app/main.py should be present.
There was a problem hiding this comment.
You should rollback all changes that you have made in README.md. Your Readme must be the same as on main branch
There was a problem hiding this comment.
You can use git checkout -p master -- README.md. But make sure that you are on develop branch
README.md
Outdated
| and store `name`, `age` of a person. | ||
| This class also should have a class attribute | ||
| `people`, it is a dict that stores `Person` | ||
| instances by their `name`. Constructor should | ||
| instances by their `name`. The `__init__` method should |
There was a problem hiding this comment.
Yes, remove this file from the PR, please. Only app/main.py should be present.
There was a problem hiding this comment.
You should not remove the README.md file from the repository, you should not apply any changes to it. Recreate it with the content from here and make a new commit to resolve the conflicts and run tests.
|
created file README.md, clicked on here and added the text. |
README.md
Outdated
| and store `name`, `age` of a person. | ||
| This class also should have a class attribute | ||
| `people`, it is a dict that stores `Person` | ||
| instances by their `name`. Constructor should | ||
| instances by their `name`. The `__init__` method should |
There was a problem hiding this comment.
You should rollback all changes that you have made in README.md. Your Readme must be the same as on main branch
|
|
app/main.py
Outdated
| # write your code here | ||
| pass | ||
|
|
||
| people_list = [] |
There was a problem hiding this comment.
In this variable first of all you should create list of Person objects, instead of doing this in regular cycle
| people_list = [Person(person["name"], person["age"]) for person in people] | ||
|
|
||
| for person in people: | ||
| person1 = Person.people[person["name"]] |
There was a problem hiding this comment.
This is not another person to name it person1, it's just an object of person. So, to name variable more specific, better to name it person_object or smth like that.
No description provided.