Solution #890
Solution #890
Conversation
app/main.py
Outdated
| """ | ||
|
|
||
| :param incoming_list: | ||
| :return: |
There was a problem hiding this comment.
There is no need to use a docstring as it is a simple function
app/main.py
Outdated
| persons_list = [] | ||
| for part_of_list in incoming_list: | ||
| name = part_of_list["name"] | ||
| age = part_of_list["age"] | ||
| person = Person(name, age) | ||
| persons_list.append(person) |
There was a problem hiding this comment.
Consider using a list comprehension to create a list ofPerson
app/main.py
Outdated
| age = part_of_list["age"] | ||
| person = Person(name, age) | ||
| persons_list.append(person) | ||
| for i, part_of_list in enumerate(incoming_list): |
There was a problem hiding this comment.
By using a more descriptive name like indexinstead of i you make your code more readable and help others understand the purpose of the loop variable
app/main.py
Outdated
| if part_of_list.get("wife"): | ||
| persons_list[i].wife = \ | ||
| Person.people[part_of_list.get("wife")] | ||
| if part_of_list.get("husband"): | ||
| persons_list[i].husband = \ | ||
| Person.people[part_of_list.get("husband")] |
There was a problem hiding this comment.
you can split lines without using backslashes by enclosing the expression in parentheses.
app/main.py
Outdated
| # write your code here | ||
| pass | ||
|
|
||
| def create_person_list(incoming_list: list) -> list: |
There was a problem hiding this comment.
| def create_person_list(incoming_list: list) -> list: | |
| def create_person_list(incoming_list: list) -> list: |
Let's rename variables because naming is so bad now
incoming_list -> people_data
persons_list -> people
part_of_list -> person
There was a problem hiding this comment.
Also,
people - багато людей
person - одна людина
app/main.py
Outdated
| people = [Person(person["name"], person["age"]) | ||
| for person in people_data] | ||
|
|
||
| for index, part_of_list in enumerate(people_data): |
No description provided.