Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #355

wants to merge 1 commit into from

Conversation

zaietsmo
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the web scraper! 🎉 Your code meets all the core requirements and successfully extracts quotes from the website, storing them in a CSV file. While the use of repr for tags could be improved for better readability, it's a minor issue that doesn't impact the functionality. Keep up the good work and consider using ', '.join(quote.tags) for a cleaner CSV output in the future. Happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +47 to +48
tags_str = repr(quote.tags)
writer.writerow([quote.text, quote.author, tags_str])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using repr to convert the list of tags to a string might not be the best choice for CSV output, as it includes the list syntax (e.g., brackets and quotes). Consider using ', '.join(quote.tags) to create a more readable string of tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants