solution #356
solution #356
Conversation
There was a problem hiding this comment.
Great job on implementing the solution! 🎉 The code meets all the task requirements and constraints effectively. While there are some minor improvements suggested regarding type hinting, these do not impact the functionality of your code. Keep up the good work and consider refining the type hints for even clearer code in the future. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| ) | ||
|
|
||
|
|
||
| def get_single_page_quotes(soup: Tag) -> [Quote]: |
There was a problem hiding this comment.
The return type hint [Quote] should be List[Quote] from the typing module for better clarity and to avoid confusion. This requires importing List from typing.
| return [parse_single_quote(quote) for quote in quotes] | ||
|
|
||
|
|
||
| def get_all_quotes() -> [Quote]: |
There was a problem hiding this comment.
Similar to the previous comment, the return type hint [Quote] should be List[Quote] from the typing module. Ensure to import List from typing.
| return all_quotes | ||
|
|
||
|
|
||
| def write_quotes_to_csv(quotes: [Quote], path: str) -> None: |
There was a problem hiding this comment.
The type hint for the quotes parameter should be List[Quote] instead of [Quote] for consistency and clarity. Import List from typing if not already done.
No description provided.