Solution #361
Open
Solution #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Your code is well-structured and meets the task requirements effectively! 🎉 While there are a couple of minor issues, such as the incorrect use of select_one instead of select and the need to update type annotations to List[Quote], these do not significantly impact the functionality. Great job on handling pagination and ensuring all quotes are scraped! Keep up the good work and consider these improvements for even cleaner code in the future. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| ) | ||
|
|
||
|
|
||
| def get_single_quote_page(page_soup: Tag) -> [Quote]: |
There was a problem hiding this comment.
The return type annotation [Quote] should be List[Quote]. Make sure to import List from typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.