Solution #363
Solution #363
Conversation
There was a problem hiding this comment.
Great job on implementing the core functionality of the task! 🎉 Your code successfully scrapes quotes from the website and handles pagination effectively. While there are a couple of minor improvements suggested, such as ensuring correct URL concatenation and considering the file mode for CSV writing, these do not impact the overall functionality. Keep up the good work and consider these suggestions for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| next_page = get_next_page(soup) | ||
| if not next_page: | ||
| break | ||
| text = requests.get(URL + next_page).content |
There was a problem hiding this comment.
Ensure that next_page contains a leading slash or is correctly formatted to prevent incorrect URL concatenation. Consider using urljoin from the urllib.parse module for safer URL concatenation.
| pass | ||
| with open( | ||
| output_csv_path, | ||
| "a", |
There was a problem hiding this comment.
The file is opened in append mode ('a'), which will add new data to the existing file content. If you want to overwrite the file each time the script runs, consider using write mode ('w') instead.
No description provided.