Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a solution #367

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

MaksymProtsak
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the code! 🎉 It meets the task requirements and successfully scrapes quotes from the website, handling pagination effectively. Just a couple of minor tweaks: consider correcting the typo in the function name to parse_single_quote for clarity, and remove the unnecessary comma in the requests.get call. Keep up the good work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/parse.py Outdated


def get_soup_page(url: str) -> BeautifulSoup:
r = requests.get(url, ).content

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unnecessary comma after requests.get(url, ). It should be removed to avoid confusion.

return quotes


def pars_single_quote(quote: Tag) -> Quote:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function name pars_single_quote seems to be a typo. It should be parse_single_quote to maintain consistency and clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants