Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #370

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #370

wants to merge 3 commits into from

Conversation

VlaBeh
Copy link

@VlaBeh VlaBeh commented Jan 22, 2025

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is well-structured and effectively meets the task requirements by successfully scraping quotes and saving them to a CSV file. 🎉 There are a couple of minor issues to address: ensure compatibility with Python versions prior to 3.9 by using List[str] from the typing module for type hints, and correct the import statement for astuple. Keep up the great work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -1,4 +1,10 @@
from dataclasses import dataclass
from dataclasses import dataclass, fields, astuple

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement for astuple is incorrect. It should be from dataclasses import astuple instead of from dataclasses, fields, astuple.

@@ -8,8 +14,46 @@
tags: list[str]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint list[str] is only valid in Python 3.9 and later. If you need compatibility with earlier versions, consider using List[str] from the typing module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants