Develop #404
Open
Develop #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YukihiroSM
suggested changes
Oct 8, 2023
app/car.py
Outdated
There was a problem hiding this comment.
The file is still not fixed. Try to recreate the file and rewrite the code.
app/customer.py
Outdated
There was a problem hiding this comment.
The file is still not fixed. Try to recreate the file and rewrite the code.
|
I rewrote the code, but it still didn't help, I don't understand how to do it |
ArsenPidhoretskyi
suggested changes
Oct 12, 2023
README.md
Outdated
Comment on lines
5
to
7
|
|
||
|
|
||
| #You want to create an application that helps customers to choose the cheapest |
README.md
Outdated
Comment on lines
144
to
146
|
|
||
|
|
||
| ### Note: Check your code using this [checklist](checklist.md) before pushing your solution. |
app/car.py
Outdated
app/customer.py
Outdated
ArsenPidhoretskyi
suggested changes
Oct 13, 2023
app/customer.py
Outdated
app/shop.py
Outdated
| if product in self.products: | ||
| cost = self.products[product] * amount | ||
| spent_money += cost | ||
| if cost % 1 == 0: |
There was a problem hiding this comment.
You can use cost.is_integer()
car.py
Outdated
There was a problem hiding this comment.
Why you also need duplicate of file?
castomer.py
Outdated
There was a problem hiding this comment.
Why you also need duplicate of file?
cer.py
Outdated
app/customer.py
Outdated
app/castomer.py
Outdated
There was a problem hiding this comment.
Rename this file into customer.py
YukihiroSM
suggested changes
Oct 15, 2023
app/shop.py
Outdated
| if product in self.products: | ||
| cost = self.products[product] * amount | ||
| spent_money += cost | ||
| if cost % 1 == 0: |
car.py
Outdated
castomer.py
Outdated
cer.py
Outdated
app/castomer.py
Outdated
app/customer.py
Outdated
YukihiroSM
suggested changes
Nov 5, 2023
There was a problem hiding this comment.
Remove not needed files from git, please.
https://sentry.io/answers/delete-a-file-from-a-git-repository/
EdAlekseiev
reviewed
Nov 7, 2023
castomer.py
Outdated
cer.py
Outdated
EdAlekseiev
suggested changes
Nov 7, 2023
EdAlekseiev
reviewed
Nov 10, 2023
app/shop.py
Outdated
Comment on lines
23
to
44
| def generate_receipt(self, customer: str, current_time: str) -> str: | ||
| receipt = f"Date: {current_time}\nThanks, {customer.name}," \ | ||
| f" for your purchase!\nYou have bought: \n" | ||
| total_cost = 0 | ||
| for product, quantity in customer.product_cart.items(): | ||
| if product in self.product_cart: | ||
| product_cost = self.product_cart[product] | ||
| product_total_cost = product_cost * quantity | ||
| if product_total_cost % 1 == 0: | ||
| receipt += ( | ||
| f"{quantity} {product}s for " | ||
| f"{int(product_total_cost)} dollars\n" | ||
| ) | ||
| else: | ||
| receipt += ( | ||
| f"{quantity} {product}s for " | ||
| f"{product_total_cost} dollars" | ||
| ) | ||
| total_cost += product_total_cost | ||
| receipt += f"\nTotal cost is {total_cost} dollars\nSee " \ | ||
| f"you again!\n\n{customer.name} rides home" | ||
| return receipt |
There was a problem hiding this comment.
Suggested change
| def generate_receipt(self, customer: str, current_time: str) -> str: | |
| receipt = f"Date: {current_time}\nThanks, {customer.name}," \ | |
| f" for your purchase!\nYou have bought: \n" | |
| total_cost = 0 | |
| for product, quantity in customer.product_cart.items(): | |
| if product in self.product_cart: | |
| product_cost = self.product_cart[product] | |
| product_total_cost = product_cost * quantity | |
| if product_total_cost % 1 == 0: | |
| receipt += ( | |
| f"{quantity} {product}s for " | |
| f"{int(product_total_cost)} dollars\n" | |
| ) | |
| else: | |
| receipt += ( | |
| f"{quantity} {product}s for " | |
| f"{product_total_cost} dollars" | |
| ) | |
| total_cost += product_total_cost | |
| receipt += f"\nTotal cost is {total_cost} dollars\nSee " \ | |
| f"you again!\n\n{customer.name} rides home" | |
| return receipt | |
| def generate_receipt(self, customer: str, current_time: str, fuel_price: float) -> str: | |
| receipt = f"Date: {current_time}\nThanks, {customer.name}," \ | |
| f" for your purchase!\nYou have bought: \n" | |
| total_cost = 0 | |
| for product, quantity in customer.product_cart.items(): | |
| if product in self.product_cart: | |
| product_cost = self.product_cart[product] | |
| product_total_cost = product_cost * quantity | |
| if product_total_cost % 1 == 0: | |
| receipt += ( | |
| f"{quantity} {product}s for " | |
| f"{int(product_total_cost)} dollars\n" | |
| ) | |
| else: | |
| receipt += ( | |
| f"{quantity} {product}s for " | |
| f"{product_total_cost} dollars" | |
| ) | |
| total_cost = customer.calculate_trip_cost(self, fuel_price) | |
| receipt += f"\nTotal cost is {total_cost} dollars\nSee " \ | |
| f"you again!\n\n{customer.name} rides home" | |
| return receipt |
EdAlekseiev
suggested changes
Nov 11, 2023
app/shop.py
Outdated
| fuel_price: float | ||
| ) -> str: | ||
| receipt = f"Date: {current_time}\nThanks, {customer.name}," \ | ||
| f" for your purchase!\nYou have bought: \n" |
There was a problem hiding this comment.
Suggested change
| f" for your purchase!\nYou have bought: \n" | |
| f" for your purchase!\nYou have bought:\n" |
There was a problem hiding this comment.
I tried your option, but then the test crashes, doesn't want to, a space is needed there
There was a problem hiding this comment.
the tests are fixed on git already. You have old version, so just remove the space here, please.
YukihiroSM
suggested changes
Nov 11, 2023
app/shop.py
Outdated
| fuel_price: float | ||
| ) -> str: | ||
| receipt = f"Date: {current_time}\nThanks, {customer.name}," \ | ||
| f" for your purchase!\nYou have bought: \n" |
There was a problem hiding this comment.
the tests are fixed on git already. You have old version, so just remove the space here, please.
ArsenPidhoretskyi
suggested changes
Nov 11, 2023
app/main.py
Outdated
|
|
||
|
|
||
| def shop_trip() -> str: | ||
| global shop |
app/main.py
Outdated
| shops_data = config_data["shops"] | ||
|
|
||
| customers = [] | ||
| cars = [] |
There was a problem hiding this comment.
This list is redundant no need to store cars
app/shop.py
Outdated
Comment on lines
18
to
20
| total_cost = 0 | ||
| for product in product_cart.keys(): | ||
| total_cost += self.product_cart[product] * product_cart[product] |
There was a problem hiding this comment.
Use sum() function
Also, use .items instead of .keys()
app/shop.py
Outdated
Comment on lines
36
to
45
| if product_total_cost % 1 == 0: | ||
| receipt += ( | ||
| f"{quantity} {product}s for " | ||
| f"{int(product_total_cost)} dollars\n" | ||
| ) | ||
| else: | ||
| receipt += ( | ||
| f"{quantity} {product}s for " | ||
| f"{product_total_cost} dollars" | ||
| ) |
There was a problem hiding this comment.
Suggested change
| if product_total_cost % 1 == 0: | |
| receipt += ( | |
| f"{quantity} {product}s for " | |
| f"{int(product_total_cost)} dollars\n" | |
| ) | |
| else: | |
| receipt += ( | |
| f"{quantity} {product}s for " | |
| f"{product_total_cost} dollars" | |
| ) | |
| if product_total_cost.is_integer(): | |
| product_total_cost = int(product_total_cost) | |
| receipt += ( | |
| f"{quantity} {product}s for " | |
| f"{product_total_cost} dollars" | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.