Solution-py-shop-trip #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimosphen1
suggested changes
Oct 11, 2023
|
I resolved flake8 errors. |
|
I don't understand why it is not possible to import: : ImportError: cannot import name 'Customer' |
Dimosphen1
suggested changes
Oct 11, 2023
app/shop/shop.py
Outdated
| import datetime | ||
| from typing import Dict, Any | ||
|
|
||
| from app.customer.customer import Customer |
There was a problem hiding this comment.
You cannot import Customer here because you import Shop inside of the app/customer/customer.py. You could read more about cyclic imports in Python and try to resolve them by reformatting the project structure upon the next pull request.
|
I have an issue with calculation. |
Dimosphen1
suggested changes
Oct 12, 2023
|
|
||
| def shop_trip() -> None: | ||
| with open("app/config.json", "r") as config_file: | ||
| config_data = json.load(config_file) |
There was a problem hiding this comment.
Do not overload the context manager, place logic not related to the file management outside of its scope.
Comment on lines
+24
to
+27
| [ | ||
| self.product_cart[product] * shop.products[product] | ||
| for product in self.product_cart | ||
| ] |
There was a problem hiding this comment.
Do not use list comprehension inside of sum, use generator expression instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.