Solution #678
Open
Solution #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L1nk3rrr
suggested changes
Jan 2, 2025
app/car.py
Outdated
| self.brand = brand | ||
| self.fuel_consumption = fuel_consumption | ||
|
|
||
| def fuel_needed_for_trip(self, distance: float | int) -> float | int: |
There was a problem hiding this comment.
it will return float every time, because you have division
app/customer.py
Outdated
|
|
||
| def purchases_cost(self, products: dict[str, int]) -> float | int: | ||
| costs = 0 | ||
| for product in self.product_cart.keys(): |
There was a problem hiding this comment.
Don't use keys simply do for product in self.product_cart
app/customer.py
Outdated
| def go_home(self) -> None: | ||
| print(f"{self.name} rides home") | ||
| print(f"{self.name} now has {self.money} dollars") | ||
| print("") |
There was a problem hiding this comment.
you can call empty print without empty string
app/customer.py
Outdated
| def go_buy(self, shop_name: str, costs_amount: float | int) -> None: | ||
| self.money -= costs_amount | ||
| print(f"{self.name} rides to {shop_name}") | ||
| print("") |
There was a problem hiding this comment.
you can call empty print without empty string
app/shop.py
Outdated
Comment on lines
18
to
19
| current_time = datetime.datetime.now() | ||
| current_time = current_time.strftime("%d/%m/%Y %H:%M:%S") |
There was a problem hiding this comment.
you can do it in one line
datetime.datetime.now().strftime("%d/%m/%Y %H:%M:%S")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.