Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #414

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #414

wants to merge 3 commits into from

Conversation

denys-source
Copy link

image

image

image

image

maxkatkalov
maxkatkalov approved these changes Sep 24, 2023
View reviewed changes
Copy link

@maxkatkalov maxkatkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but when u logged in – u still can access http://127.0.0.1:8000/accounts/login/ , I think it should be solved. image

Kroll410
Kroll410 suggested changes Sep 25, 2023
View reviewed changes
taxi/views.py
def index(request):
"""View function for the home page of the site."""

num_drivers = Driver.objects.count()
Copy link

@Kroll410 Kroll410 Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be looking better if placed in separete util function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kroll410 Kroll410 Kroll410 requested changes

@maxkatkalov maxkatkalov maxkatkalov approved these changes

@IvanRamyk IvanRamyk IvanRamyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denys-source @IvanRamyk @Kroll410 @maxkatkalov