Develop #427
Open
Develop #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ihor-MA
commented
Sep 26, 2023
•
Ihor-MA
commented
Serhii-Leonenko
suggested changes
Sep 26, 2023
Comment on lines
+16
to
+23
| num_visits = request.session.get("num_visits", 0) | ||
| request.session["num_visits"] = num_visits + 1 | ||
|
|
||
| context = { | ||
| "num_drivers": num_drivers, | ||
| "num_cars": num_cars, | ||
| "num_manufacturers": num_manufacturers, | ||
| "num_visits": num_visits + 1, |
There was a problem hiding this comment.
does it work correctly, you add 1 for two times? Also, you can try to use dict setdefault() method here
There was a problem hiding this comment.
Yes, it works well, in request.session["num_visits"] = num_visits + 1, we add 1 to 'num_visits' in Session data, in the context we add 1 to show user the variable num_visits' before the page reloads. if we use "num_visits": num_visits , we will see 0 times in the page, however in in Session data 'num_visits' will be 1. It was shown in video, so i think it is good solution
Serhii-Leonenko
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.