Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication realization #465

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MiskoRuslan
Copy link

No description provided.

@MiskoRuslan
Copy link
Author

Screenshot_5
Screenshot_6
Screenshot_7
Screenshot_8
Screenshot_9

context = {
"num_drivers": num_drivers,
"num_cars": num_cars,
"num_manufacturers": num_manufacturers,
"num_visits": num_visits + 1
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have "num_visit" == 1?
Looks like you make +1 two times

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I separately iterate through request.session["num_visits"] and display the pre-assigned value num_visits + 1 :)

{% if user.is_authenticated %}
<a href="drivers/{{ user.id }}/">User: {{ user.username }}</a>
<a href="{% url "logout" %}">Log Out</a>
{% else %}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be nice to add
between User and Login and Logout. Now it is all in one line

@MiskoRuslan
Copy link
Author

fix view format
image

Copy link

@LiudmylaKulinchenko LiudmylaKulinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🌷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants