Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #490

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

solution #490

wants to merge 7 commits into from

Conversation

vsafian
Copy link

@vsafian vsafian commented Nov 22, 2023

No description provided.

@vsafian
Copy link
Author

vsafian commented Nov 22, 2023

image
image

taxi/models.py Outdated
@@ -29,5 +29,5 @@ class Car(models.Model):
manufacturer = models.ForeignKey(Manufacturer, on_delete=models.CASCADE)
drivers = models.ManyToManyField(Driver, related_name="cars")

def __str__(self):
def __str__(self) -> model:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It returns str

taxi/models.py Outdated
def __str__(self):
return self.model
def __str__(self) -> str:
return f"{self.model}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f-string is redundant

Copy link

@vasylhnatiuk vasylhnatiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls delete db.sqlite3 from pr. and it in .gitignore

@vsafian vsafian requested a review from vasylhnatiuk November 23, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants