Done #745
Open
Done #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsmutok
suggested changes
Aug 5, 2024
taxi/views.py
Outdated
Comment on lines
56
to
75
|
|
||
|
|
||
| def login_view(request: HttpRequest) -> HttpResponse: | ||
| if request.method == "GET": | ||
| form = AuthenticationForm() | ||
| return render(request, "registration/login.html", {"form": form}) | ||
| elif request.method == "POST": | ||
| form = AuthenticationForm(data=request.POST) | ||
| if form.is_valid(): | ||
| user = form.get_user() | ||
| login(request, user) | ||
| return HttpResponseRedirect(reverse("taxi:index")) | ||
| else: | ||
| return render(request, "registration/login.html", {"form": form}) | ||
|
|
||
|
|
||
| def logout_view(request) -> HttpResponse: | ||
| form = AuthenticationForm() | ||
| logout(request) | ||
| return render(request, "registration/logged_out.html", {"form": form}) |
There was a problem hiding this comment.
These two views are unnecessary here, please use the logic and logout provided by Django out of the box, don't write your own view.
Comment on lines
-23
to
-25
| SECRET_KEY = ( | ||
| SECRET_KEY = \ | ||
| "django-insecure-8ovil3xu6=eaoqd#-#&ricv159p0pypoh5_lgm*)-dfcjqe=yc" | ||
| ) |
There was a problem hiding this comment.
Why you change this?
Better to use () then \
There was a problem hiding this comment.
Flake8 said that it is too much of symbols
viktoria-rybenchuk
suggested changes
Aug 5, 2024
requirements.txt
Outdated
| flake8==5.0.4 | ||
| flake8-quotes==3.3.1 | ||
| flake8-variables-names==0.0.5 | ||
| pep8-naming==0.13.2 | ||
|
|
||
| django-debug-toolbar~=4.4.6 |
| {% extends "base.html" %} | ||
| {% block content %} | ||
| <p>You logged out of the site, to go back use this link:<a href="{% url "login" %}" class="btn btn-primary">Login</a></p> | ||
| {% endblock %} |
viktoria-rybenchuk
suggested changes
Aug 5, 2024
requirements.txt
Outdated
| flake8==5.0.4 | ||
| flake8-quotes==3.3.1 | ||
| flake8-variables-names==0.0.5 | ||
| pep8-naming==0.13.2 | ||
|
|
There was a problem hiding this comment.
remove an unnecessary blank line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.