Develop #749
Open
Develop #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-gj
commented
Aug 8, 2024
oleg-gj
commented
pavlopro
suggested changes
Aug 8, 2024
taxi/migrations/0001_initial.py
Outdated
| @@ -29,7 +29,7 @@ class Migration(migrations.Migration): | |||
| ('last_name', models.CharField(blank=True, max_length=150, verbose_name='last name')), | |||
There was a problem hiding this comment.
Please don't modify existing migration
LLkaia
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
In general, everything works perfect!
But there is a serious issue - you can't modify migrations. You can consider migrations as history of database structure. If developer has database with data from master branch, and then will apply yours changes and run migrate, he will see an error. He will be pushed to remove database to apply new migrations but that couldn't happen in real life.
So, never change migrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.