Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #764

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #764

wants to merge 3 commits into from

Conversation

MaksymProtsak
Copy link

image
image
image
image
image
image
image

vsmutok
vsmutok suggested changes Aug 21, 2024
View reviewed changes
taxi/views.py Outdated
Comment on lines 57 to 61
def test_session_view(request: HttpRequest) -> HttpResponse:
return HttpResponse(
"<h1>Test Session</h1>"
f"<h4>Session data: {request.session['test']}</h4>"
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this view

taxi/migrations/0001_initial.py Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not modify the migration files.

.gitignore Outdated
Comment on lines 9 to 17
/accounts/migrations/__init__.py
/accounts/__init__.py
/accounts/admin.py
/accounts/apps.py
/accounts/models.py
/accounts/tests.py
/accounts/views.py
/accounts/urls.py
/templates/registration/login.html
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this here?

@MaksymProtsak MaksymProtsak requested a review from vsmutok August 22, 2024 05:09
vsmutok
vsmutok suggested changes Aug 22, 2024
View reviewed changes
Copy link

@vsmutok vsmutok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

But please do not modify migration files. If you make changes to the models, it is better to create a new migration

@MaksymProtsak
Copy link
Author

Looks Good!

But please do not modify migration files. If you make changes to the models, it is better to create a new migration

Actualy I did not edit migration file. In first time I changed Meta for model, created migrations. After that I found solution without edigint Meta, and deleted Meta from model. Again the migration has been created.
So, maybe I did some mistake and edited migration file.

@MaksymProtsak
Copy link
Author

Looks Good!

But please do not modify migration files. If you make changes to the models, it is better to create a new migration

I remembered how I did that. I used Ctrl+Shift+R to mage changes from accounts to registrations.

@MaksymProtsak MaksymProtsak requested a review from vsmutok August 22, 2024 06:24
@MaksymProtsak
Copy link
Author

MaksymProtsak commented Aug 22, 2024 •
edited
Loading

If solution is good, please make approve)
Thank You!

vsmutok
vsmutok approved these changes Aug 22, 2024
View reviewed changes
Copy link

@vsmutok vsmutok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsmutok vsmutok vsmutok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaksymProtsak @vsmutok