Develop #792
Open
Develop #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MNDonut
suggested changes
Sep 13, 2024
| @@ -29,7 +29,7 @@ class Migration(migrations.Migration): | |||
| ('last_name', models.CharField(blank=True, max_length=150, verbose_name='last name')), | |||
| ('email', models.EmailField(blank=True, max_length=254, verbose_name='email address')), | |||
| ('is_staff', models.BooleanField(default=False, help_text='Designates whether the user can log into this admin site.', verbose_name='staff status')), | |||
| ('is_active', models.BooleanField(default=True, help_text='Designates whether this user should be treated as active. Unselect this instead of deleting accounts.', verbose_name='active')), | |||
There was a problem hiding this comment.
do you need this change?
you should use auto replace carefully and check what it changes before applying changes because migrations may fail ;)
MNDonut
suggested changes
Sep 13, 2024
MNDonut
suggested changes
Sep 16, 2024
Oleksl888
reviewed
Sep 17, 2024
| @@ -22,4 +22,8 @@ | |||
| urlpatterns = [ | |||
| path("admin/", admin.site.urls), | |||
| path("", include("taxi.urls", namespace="taxi")), | |||
| ] + static(settings.STATIC_URL, document_root=settings.STATIC_ROOT) | |||
| path("registration/", include("django.contrib.auth.urls")), | |||
There was a problem hiding this comment.
I wonder how this path works for you without setting LOGIN_URL in settings 🤔
Default path for auth urls in django is accounts/ and it will not resolve default login/logout with a different name unless you specify LOGIN_URL
Oleksl888
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.