Solution.. Here we go again #796
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Oleksl888
suggested changes
Sep 13, 2024
taxi/urls.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| from django.urls import path | |||
| from django.urls import path, include | |||
There was a problem hiding this comment.
you don't need to change anything in this file - just revert
taxi/views.py
Outdated
| def index(request): | ||
| """View function for the home page of the site.""" | ||
|
|
||
| num_drivers = Driver.objects.count() | ||
| num_cars = Car.objects.count() | ||
| num_manufacturers = Manufacturer.objects.count() | ||
| num_visits = request.session.get("num_visits", 0) | ||
| request.session["num_visits"] = num_visits + 1 |
There was a problem hiding this comment.
you can add +1 in a statement above and then you will just need to pass num_visits without addition here and below
taxi_service/urls.py
Outdated
| @@ -22,4 +22,5 @@ | |||
| urlpatterns = [ | |||
| path("admin/", admin.site.urls), | |||
| path("", include("taxi.urls", namespace="taxi")), | |||
| path("account/", include("django.contrib.auth.urls"), name="login"), | |||
There was a problem hiding this comment.
do you need to set name="login") here?
MNDonut
suggested changes
Sep 16, 2024
taxi/views.py
Outdated
Comment on lines
17
to
25
| num_visits = request.session.get("num_visits", 1) | ||
| request.session["num_visits"] = num_visits + 1 | ||
|
|
||
| context = { | ||
| "num_drivers": num_drivers, | ||
| "num_cars": num_cars, | ||
| "num_manufacturers": num_manufacturers, | ||
| "num_visits": num_visits + 1, | ||
| "num_visits": num_visits, | ||
| } |
There was a problem hiding this comment.
how do you think, num_visits contains number or reference?
Because let's imagine that request.session.num_visits is 5
Then
num_visits = 5
request.session.num_visits = 6
then what is num_visits? 5 or 6? Does it contain reference to some object and number will be automatically updated to 6 or it just contains a number that won't be updated?
MNDonut
suggested changes
Sep 16, 2024
taxi/views.py
Outdated
Comment on lines
16
to
18
| num_manufacturers = Manufacturer.objects.count() | ||
| num_visits = request.session.get("num_visits", 1) | ||
| num_visits = request.session.get("num_visits", 0) | ||
| request.session["num_visits"] = num_visits + 1 |
There was a problem hiding this comment.
still wrong because you show the old number of visits. you show the previous number of views but when user opens the page it should display a new number
MNDonut
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.