Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completed #801

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

completed #801

wants to merge 2 commits into from

Conversation

BGBroth
Copy link

@BGBroth BGBroth commented Sep 13, 2024

No description provided.

@BGBroth
Copy link
Author

BGBroth commented Sep 13, 2024

image
image
image

Copy link

@Dimosphen1 Dimosphen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes were requested

@@ -10,4 +10,5 @@ <h2>Dynamic content</h2>
<li><strong>Drivers:</strong> {{ num_drivers }}</li>
<li><strong>Manufacturers:</strong> {{ num_manufacturers }}</li>
</ul>
<p>Times you have visited this page: {{ num_visits }}!</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use pluralize here as mentioned in the checklist. Update the corresponding screenshot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the checklist is mentioned to use the pluralize, but I changed the phrase so that using makes no sense

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pluralize filter automatically decides whether to add an "s" to word based on the value of num_visits. This makes your templates more dynamic and grammatically correct according to the quantity.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity and correctness, better rephrase
You have visited this page {{ num_visits }} time{{ num_visits|pluralize }}!

@BGBroth BGBroth requested a review from Dimosphen1 September 13, 2024 10:24
@@ -10,4 +10,5 @@ <h2>Dynamic content</h2>
<li><strong>Drivers:</strong> {{ num_drivers }}</li>
<li><strong>Manufacturers:</strong> {{ num_manufacturers }}</li>
</ul>
<p>Times you have visited this page: {{ num_visits }}!</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pluralize filter automatically decides whether to add an "s" to word based on the value of num_visits. This makes your templates more dynamic and grammatically correct according to the quantity.

@@ -10,4 +10,5 @@ <h2>Dynamic content</h2>
<li><strong>Drivers:</strong> {{ num_drivers }}</li>
<li><strong>Manufacturers:</strong> {{ num_manufacturers }}</li>
</ul>
<p>Times you have visited this page: {{ num_visits }}!</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity and correctness, better rephrase
You have visited this page {{ num_visits }} time{{ num_visits|pluralize }}!

Copy link

@pavlopro pavlopro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants