-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completed #801
base: master
Are you sure you want to change the base?
completed #801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several changes were requested
templates/taxi/index.html
Outdated
@@ -10,4 +10,5 @@ <h2>Dynamic content</h2> | |||
<li><strong>Drivers:</strong> {{ num_drivers }}</li> | |||
<li><strong>Manufacturers:</strong> {{ num_manufacturers }}</li> | |||
</ul> | |||
<p>Times you have visited this page: {{ num_visits }}!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, use pluralize
here as mentioned in the checklist. Update the corresponding screenshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the checklist is mentioned to use the pluralize, but I changed the phrase so that using makes no sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pluralize filter automatically decides whether to add an "s" to word based on the value of num_visits. This makes your templates more dynamic and grammatically correct according to the quantity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarity and correctness, better rephrase
You have visited this page {{ num_visits }} time{{ num_visits|pluralize }}!
templates/taxi/index.html
Outdated
@@ -10,4 +10,5 @@ <h2>Dynamic content</h2> | |||
<li><strong>Drivers:</strong> {{ num_drivers }}</li> | |||
<li><strong>Manufacturers:</strong> {{ num_manufacturers }}</li> | |||
</ul> | |||
<p>Times you have visited this page: {{ num_visits }}!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pluralize filter automatically decides whether to add an "s" to word based on the value of num_visits. This makes your templates more dynamic and grammatically correct according to the quantity.
templates/taxi/index.html
Outdated
@@ -10,4 +10,5 @@ <h2>Dynamic content</h2> | |||
<li><strong>Drivers:</strong> {{ num_drivers }}</li> | |||
<li><strong>Manufacturers:</strong> {{ num_manufacturers }}</li> | |||
</ul> | |||
<p>Times you have visited this page: {{ num_visits }}!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarity and correctness, better rephrase
You have visited this page {{ num_visits }} time{{ num_visits|pluralize }}!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
No description provided.