-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxi-authentication #857
base: master
Are you sure you want to change the base?
taxi-authentication #857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the Django application! 🎉 The code is well-structured and meets most of the task requirements. Just a small note: there's a typo in the login page title ("Loggin" instead of "Login"). Fixing this will enhance clarity. Keep up the good work and continue improving your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
{% extends "base.html" %} | ||
|
||
{% block content %} | ||
<h1>Loggin</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the heading: 'Loggin' should be corrected to 'Login'.
|
||
context = { | ||
"num_drivers": num_drivers, | ||
"num_cars": num_cars, | ||
"num_manufacturers": num_manufacturers, | ||
"num_visits": request.session.get("num_visits") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in this case (if i understood correctly) you will use databases twice:
firs time
num_visits = request.session.get("num_visits", 0)
second time
context = {
...
"num_visits": request.session.get("num_visits"),
}
I think it will better if you will use one time like that:
num_visits = request.session.get("num_visits", 0) + 1
request.session["num_visits"] = num_visits
context = {
...
"num_visits": num_visits
}
No description provided.