Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I just want to check the tests #891

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yablonskyiv
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The code is well-structured and meets the core requirements. While there are minor improvements suggested, such as removing unused imports and ensuring no database files are pushed, these do not impact the functionality. Keep up the good work and consider these suggestions for future projects! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

taxi/urls.py Outdated Show resolved Hide resolved
taxi/urls.py Outdated Show resolved Hide resolved
@yablonskyiv
Copy link
Author

1
2

Copy link

@vsmutok vsmutok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Comment on lines 32 to 33
LOGIN_URL = "/accounts/login/" # URL для входу
LOGIN_REDIRECT_URL = "/" # Куди перенаправляти після успішного входу
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to write all code comments in English.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, it was just for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants