Solution #402
Open
Solution #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaCtUs1k
commented
Sep 25, 2023
•
CaCtUs1k
commented
Serhii-Leonenko
suggested changes
Sep 26, 2023
Comment on lines
1
to
9
| {% extends "base.html" %} | ||
| {% block content %} | ||
| <h1>Delete car</h1> | ||
| <p>Are you sure you want to delete the car: {{ car.model }}?</p> | ||
| <form action="" method="post"> | ||
| {% csrf_token %} | ||
| <input type="submit" value="Yes!" class="btn btn-danger"> | ||
| </form> | ||
| {% endblock %} |
There was a problem hiding this comment.
Don't forget about blank line, also you have to read the checklist
There was a problem hiding this comment.
the same in other similar cases
taxi/views.py
Outdated
| model = Manufacturer | ||
| fields = "__all__" | ||
| success_url = reverse_lazy("taxi:manufacturer-list") | ||
| template_name = "taxi/manufacturer_form.html" |
There was a problem hiding this comment.
Do you need to redefine the template name?
Serhii-Leonenko
suggested changes
Sep 27, 2023
taxi/views.py
Outdated
| model = Car | ||
| fields = "__all__" | ||
| success_url = reverse_lazy("taxi:car-list") | ||
| template_name = "taxi/car_form.html" |
templates/taxi/car_form.html
Outdated
| {{ form|crispy }} | ||
| <input class="btn btn-primary" type="submit" value="Submit"> | ||
| </form> | ||
| {% endblock %} |
There was a problem hiding this comment.
and you forget blank line here
Serhii-Leonenko
suggested changes
Sep 28, 2023
taxi/views.py
Outdated
|
|
||
| class ManufacturerDeleteView(LoginRequiredMixin, generic.DeleteView): | ||
| model = Manufacturer | ||
| template_name = "taxi/manufacturer_confirm_delete.html" |
There was a problem hiding this comment.
what about _confirm_delete templates, which default name Django use for them?)
Serhii-Leonenko
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.